[refactor] deprecate db/common/role.DatabaseRoleMatchers#34132
Merged
[refactor] deprecate db/common/role.DatabaseRoleMatchers#34132
Conversation
20916ce to
82e41b1
Compare
Tener
approved these changes
Nov 2, 2023
Contributor
Tener
left a comment
There was a problem hiding this comment.
In theory one may forget to supply one of (db, db user, db name) as these are now optional fields in the config. In practice I think this is unlikely.
Contributor
|
I think we should update EnumerateDatabaseUsers to be aware of auto-provisioning, but perhaps this can be a separate PR. teleport/lib/services/access_checker.go Lines 565 to 574 in 93e6ec6 |
Contributor
Author
Good call. Will do a separate fix. |
10 tasks
smallinsky
approved these changes
Nov 9, 2023
greedy52
added a commit
that referenced
this pull request
Dec 3, 2023
* [refactor] deprecate db/common/role.DatabaseRoleMatchers * fix typo * fix a small typo
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
* [refactor] deprecate db/common/role.DatabaseRoleMatchers (#34132) * [refactor] deprecate db/common/role.DatabaseRoleMatchers * fix typo * fix a small typo * Restore DatabaseRoleMatchers to avoid e breakage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-req for MongoDB auto-user provisioning change #33717
Changes:
role.DatabaseRoleMatchersDisableDatabaseNameMatcherflag torole.RoleMatchersConfigrole.GetDatabaseRoleMatchersa little bit and added UTNo backporting necessary.