Installer Scripts: use bash instead of sh#34039
Merged
marcoandredinis merged 2 commits intomasterfrom Nov 2, 2023
Merged
Conversation
The agentless version of this script uses `bash`. Using `bash` over `sh` should help the maitenance of the script. It's being used for the agentless version and the node join script `sh` is sometimes an alias to `bash`, and testing this script in those systems might lead to assume that the script is working fine, even tho when running in a real `sh` it will fail.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Tener
approved these changes
Oct 31, 2023
jakule
approved these changes
Nov 1, 2023
|
@marcoandredinis See the table below for backport results.
|
This was referenced Nov 2, 2023
marcoandredinis
added a commit
that referenced
this pull request
Nov 2, 2023
* Installer Scripts: use bash instead of sh The agentless version of this script uses `bash`. Using `bash` over `sh` should help the maitenance of the script. It's being used for the agentless version and the node join script `sh` is sometimes an alias to `bash`, and testing this script in those systems might lead to assume that the script is working fine, even tho when running in a real `sh` it will fail. * use the same expression that is being used in agentless
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Installer Scripts: use bash instead of sh The agentless version of this script uses `bash`. Using `bash` over `sh` should help the maitenance of the script. It's being used for the agentless version and the node join script `sh` is sometimes an alias to `bash`, and testing this script in those systems might lead to assume that the script is working fine, even tho when running in a real `sh` it will fail. * use the same expression that is being used in agentless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agentless version of this script uses
bash.Using
bashovershshould help the maintenance of the script. It's being used for the agentless version and the node join scriptshis sometimes an alias tobash, and testing this script in those systems might lead to assume that the script is working fine, even tho when running in a realshit will fail.changelog: use
bashinstead ofshfor the Server Auto-Discovery installer scriptRelated #31914