desktop access: soften the disconnect error#33941
Merged
Conversation
zmb3
added
backport/branch/v12
no-changelog
zmb3
force-pushed
the
zmb3/soften-desktop-disconnect
branch
from
d9a209d to
053fd95
Compare
ryanclark
approved these changes
Oct 31, 2023
rosstimothy
approved these changes
Oct 31, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
Collaborator
Author
|
Note to self that we should do the same when playing back a session recording. |
If the Windows host (RDP server) decides to terminate the connection, it often sends a message indicating why the disconnect is coming. One example of a server-initiated disconnect would be when the user clicks "log off" in the RDP session or when they restart the remote machine. We forward this message to the UI, but we put it in a big red ERROR box that makes it look like something went wrong. Errors should be reserved for unexpected disconnections, so covert the dialog to "info" level and soften the messaging.
zmb3
force-pushed
the
zmb3/soften-desktop-disconnect
branch
from
053fd95 to
014653d
Compare
Collaborator
Author
|
@ibeckermayer take a look at the latest commit and let me know what you think. Instead of changing all cases of this error from |
zmb3
commented
Nov 7, 2023
Collaborator
Author
There was a problem hiding this comment.
This has been a bug for a loooong time. We ignore the length that the server sends and just assume the rest of the message is one giant string. (Which is why we often see unprintable characters at the end of the error message).
zmb3
commented
Nov 7, 2023
With the prior commit, we successfully made server-side disconnects look less like errors, but we also made some real errors (like connection time outs) look less like errors. Now, we render an error indicator when we have an unexpected disconnect. We also add a special check for "RDP connection failed" which is used to indicate that the connection was never established succesfully. This also fixes an ancient bug where our strings had an extra unprintable byte at the end. This is because the TDP codec was interpreting the "severity" byte as part of the string, rather than reading only the length that was specified in the message.
zmb3
force-pushed
the
zmb3/soften-desktop-disconnect
branch
from
014653d to
c82328b
Compare
ibeckermayer
approved these changes
Nov 9, 2023
This was referenced Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the Windows host (RDP server) decides to terminate the connection, it often sends a message indicating why the disconnect is coming. One example of a server-initiated disconnect would be when the user clicks "log off" in the RDP session or when they restart the remote machine.
We forward this message to the UI, but we put it in a big red ERROR box that makes it look like something went wrong.
Errors should be reserved for unexpected disconnections, so covert the dialog to "info" level and soften the messaging.
Before:
After: