Merged
Conversation
greedy52
added
aws
GavinFrazar
approved these changes
Oct 27, 2023
Contributor
GavinFrazar
left a comment
GavinFrazar
left a comment
There was a problem hiding this comment.
I didn't test it but LGTM
smallinsky
approved these changes
Nov 8, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from tcsc
greedy52
force-pushed
the
STeve/33068/memorydb_iam_auth
branch
from
dc51063 to
d7f2d98
Compare
greedy52
force-pushed
the
STeve/33068/memorydb_iam_auth
branch
from
d7f2d98 to
1c46092
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
greedy52
added a commit
that referenced
this pull request
Nov 8, 2023
* Added IAM Authentication support for Amazon MemoryDB Access * update configurator * minor typos * address review comments
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
* MemoryDB IAM auth support (#33937) * Added IAM Authentication support for Amazon MemoryDB Access * update configurator * minor typos * address review comments * fix UT * add a comment on the "iam" memorydb auth type
Contributor
Author
|
ElastiCache IAM Auth was not back ported in v12 so will not backport this to v12 either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Added IAM Authentication support for Amazon MemoryDB Access
closes #33068
Mostly just sharing/copy-paste from ElastiCache IAM auth support.
Note that branch/v12, branch/v13 has older AWS SDKs so may have to manually define auth type
iamwhen backporting (plus manual testing)Tested manual/secrets-manager/IAM AUTH for both MemoryDB and ElastiCache Redis just to make sure everything works.
Will update docs separately.