Use the correct error when inspecting Kubernetes session#33904
Merged
Use the correct error when inspecting Kubernetes session#33904
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
approved these changes
Oct 24, 2023
tigrato
force-pushed
the
tigrato/fix-report-err
branch
from
40f530c to
6dea04f
Compare
Collaborator
|
I'm not sure I agree with the changelog message. It mentions session.end but my understanding is this information is only put in the exec event, not the end event. |
This PR fixes the audit log report for Kubernetes sessions that returned errors. The previous functions was using the incorrect error variable. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/fix-report-err
branch
from
6dea04f to
3fd1a72
Compare
Contributor
Author
Oh, you are 100% correct. Changed to |
Joerger
approved these changes
Oct 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from r0mant
r0mant
approved these changes
Oct 26, 2023
tigrato
added a commit
that referenced
this pull request
Oct 26, 2023
* Use the correct error when inspecting Kubernetes session This PR fixes the audit log report for Kubernetes sessions that returned errors. The previous functions was using the incorrect error variable. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * append error to the session recorder * correct session leave code * avoid emisleading debug error when owner joins the session --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Oct 26, 2023
* Use the correct error when inspecting Kubernetes session This PR fixes the audit log report for Kubernetes sessions that returned errors. The previous functions was using the incorrect error variable. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * append error to the session recorder * correct session leave code * avoid emisleading debug error when owner joins the session --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…3952) * Use the correct error when inspecting Kubernetes session This PR fixes the audit log report for Kubernetes sessions that returned errors. The previous functions was using the incorrect error variable. * append error to the session recorder * correct session leave code * avoid emisleading debug error when owner joins the session --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…3951) * Use the correct error when inspecting Kubernetes session This PR fixes the audit log report for Kubernetes sessions that returned errors. The previous functions was using the incorrect error variable. * append error to the session recorder * correct session leave code * avoid emisleading debug error when owner joins the session --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the audit log report for Kubernetes sessions that returned errors. The previous functions used the incorrect error variable.
Changelog: Fixed an issue where Kubernetes Audit Events didn't report the correct information in the
execaudit event if the session exited with an error.