-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Handle duplicate node names & support UUID based proxying (Version 2) #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78fdf22
to
281a511
Compare
b08cd55
to
16f7a4a
Compare
Assuming we go with this approach, we should add something to the docs (probably here: https://gravitational.com/teleport/docs/cli-docs/#tctl-auth-rotate) describing what an in-place rotation is, what it does, what it doesn't do and when you might want to use it. |
95529a4
to
756848a
Compare
The rotate-in-place strategy has been shelved for now. We're opting to have nodes check their certs on startup instead. |
756848a
to
a589b05
Compare
fmt.Fprintf(os.Stderr, "Hint: try addressing the node by unique id (ex: tsh ssh user@node-id)\n") | ||
fmt.Fprintf(os.Stderr, "Hint: use 'tsh ls -v' to list all nodes with their unique ids\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Hints look good.
5569416
to
12dd87d
Compare
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. I know in the past we've used server, but we should aim to use node/nodes vs servers for consistently. It's most important for log messages and user facing input.
4fc032d
to
b90cfbb
Compare
b90cfbb
to
b1d6059
Compare
retest this please |
This PR implements an alternative strategy to the original UUID based routing strategy seen in #3340. Rather than explicitly routing by UUID, this implementation checks if the supplied hostname appears to be a UUID and guesses the intended behavior:
By treating UUIDS as hostnames, this PR is (mostly) much simpler than #3340. There is, however, one major exception: because clients treat UUIDs as hostnames, certificates now need to include UUIDs. This PR is currently a WIP since it does not yet include any mechanism for forcing nodes to get their certificates re-issued with UUIDs.
Fixes #2396