[v13] Deflake TestChaosUpload#33611
Merged
zmb3 merged 1 commit intobranch/v13from Oct 17, 2023
Merged
Conversation
This test attempted to verify that the uploader is able to operate correctly even when faults are injected into the system. It ended up being flaky for a number of reasons, but the biggest issue is that it wasn't simulating a real world scenario. 1. It used a fake clock, but never advanced it, so the uploader's scan loop didn't correctly "tick" and only ran once. 2. It invoked many uploader scans in parallel while also running the uploader's own scan loop in the background. In any real deployment we only have one scan loop running, so this test is creating an environment that never exists in the wild. Updates #33099
github-actions
Bot
added
audit-log
GavinFrazar
approved these changes
Oct 17, 2023
kimlisa
approved these changes
Oct 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33586 to branch/v13