Fix issue with ServiceNow incidents not including link to access request#33565
Merged
EdwardDowling merged 16 commits intomasterfrom Oct 17, 2023
Merged
Fix issue with ServiceNow incidents not including link to access request#33565EdwardDowling merged 16 commits intomasterfrom
EdwardDowling merged 16 commits intomasterfrom
Conversation
marcoandredinis
approved these changes
Oct 17, 2023
Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
r0mant
approved these changes
Oct 17, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
I think you need to fix the test as well but otherwise lgtm
Co-authored-by: Roman Tkachenko <roman@goteleport.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@EdwardDowling See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes link to access request in incident description, plugin status on plugin page, and incidents now get the caller field filled if possible.
Status sink added to client is set in /e PR here