Show Connect My Computer CTA only if versions are compatible#33561
Merged
Show Connect My Computer CTA only if versions are compatible#33561
Conversation
ravicious
force-pushed
the
ravicious/cmc-compatibility
branch
from
e8a53f8 to
5973c3f
Compare
gzdunek
approved these changes
Oct 17, 2023
smallinsky
approved these changes
Oct 17, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from avatus
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version would advertise Connect My Computer but then after clicking the CTA the user would see a screen explaining that they can't use Connect My Computer because of version incompatibility.
This PR fixes this by advertising Connect My Computer only if we know that the versions are compatible.