Skip to content

Fix flaky test TestWithRsync/with_headless_tsh#33538

Merged
Joerger merged 3 commits intomasterfrom
joerger/fix-flaky-test-TestWithRsync
Oct 17, 2023
Merged

Fix flaky test TestWithRsync/with_headless_tsh#33538
Joerger merged 3 commits intomasterfrom
joerger/fix-flaky-test-TestWithRsync

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Oct 16, 2023

I updated the test failure output to include the cmd's stdout/err and found the ssh agent was causing failures.

 FAIL: TestWithRsync/with_OpenSSH_ssh (0.18s)
        proxy_test.go:489: 
                Error Trace:    /home/bjoerger/gravitational/teleport-test/tool/tsh/common/proxy_test.go:489
                Error:          Received unexpected error:
                                exit status 255
                Test:           TestWithRsync/with_OpenSSH_ssh
                Messages:       exit code: 255
                                out: sign_and_send_pubkey: signing failed for RSA "/tmp/TestWithRsync3213579311/002/keys/127.0.0.1/alice": age
nt refused operation
                                sign_and_send_pubkey: signing failed for RSA "/tmp/TestWithRsync3213579311/002/keys/127.0.0.1/alice" from agen
t: agent refused operation
                                bjoerger@127.0.0.1: Permission denied (publickey).
                                rsync: connection unexpectedly closed (0 bytes received so far) [sender]
                                rsync error: unexplained error (code 255) at io.c(231) [sender=3.2.7]

Disabling the ssh agent fixes the error, since the test uses an ssh config anyways.

Fixes #32958

@Joerger Joerger requested a review from capnspacehook October 16, 2023 18:06
@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Oct 16, 2023
@Joerger Joerger marked this pull request as draft October 16, 2023 18:16
@Joerger Joerger force-pushed the joerger/fix-flaky-test-TestWithRsync branch from b2a037e to 0835074 Compare October 16, 2023 18:30
@Joerger Joerger force-pushed the joerger/fix-flaky-test-TestWithRsync branch from 0835074 to 0a53b13 Compare October 16, 2023 19:14
@Joerger Joerger marked this pull request as ready for review October 16, 2023 19:41
@github-actions github-actions Bot requested review from fheinecke and tigrato October 16, 2023 19:41
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Brian!

Copy link
Copy Markdown
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Oct 17, 2023

@Joerger in the future you can just ask Roman or I for an exception to the flaky test detector.

Excluding tests like you've done here also requires an admin approval, so it won't save you a review and it means if the test gets faster in the future we have to remember to remove it from this list.

@Joerger Joerger added this pull request to the merge queue Oct 17, 2023
Merged via the queue into master with commit d5e2623 Oct 17, 2023
@Joerger Joerger deleted the joerger/fix-flaky-test-TestWithRsync branch October 17, 2023 01:12
@public-teleport-github-review-bot
Copy link
Copy Markdown

@Joerger See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Failed
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestWithRsync/with_headless_tsh flakiness

4 participants