Fix flaky test TestWithRsync/with_headless_tsh#33538
Merged
Conversation
b2a037e to
0835074
Compare
0835074 to
0a53b13
Compare
tigrato
approved these changes
Oct 16, 2023
Collaborator
|
@Joerger in the future you can just ask Roman or I for an exception to the flaky test detector. Excluding tests like you've done here also requires an admin approval, so it won't save you a review and it means if the test gets faster in the future we have to remember to remove it from this list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the test failure output to include the cmd's stdout/err and found the ssh agent was causing failures.
Disabling the ssh agent fixes the error, since the test uses an ssh config anyways.
Fixes #32958