Add MySQL auto-user deletion#33520
Merged
gabrielcorado merged 4 commits intomasterfrom Oct 17, 2023
Merged
Conversation
github-actions
Bot
added
database-access
greedy52
approved these changes
Oct 16, 2023
Contributor
greedy52
left a comment
greedy52
left a comment
There was a problem hiding this comment.
lol, lets see if this PR will get merged first or the MariaDB change. 😈
Base automatically changed from
gabrielcorado/pg-user-auto-deletion
to
master
October 16, 2023 17:29
gabrielcorado
force-pushed
the
gabrielcorado/mysql-user-auto-deletion
branch
from
9ab3cda to
9492992
Compare
fspmarshall
approved these changes
Oct 17, 2023
Contributor
fspmarshall
left a comment
fspmarshall
left a comment
There was a problem hiding this comment.
lgtm, but take that with a grain of salt. I don't know much about sql.
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
smallinsky
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@gabrielcorado See the table below for backport results.
|
gabrielcorado
added a commit
that referenced
this pull request
Oct 19, 2023
* feat(mysql): add auto-user deletion * chore(mysql): remove unused deletion variables * test(mysql): fix race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements auto-user deletion for MySQL databases.
MySQL
DROP USERexecution fails if the user is theDEFINERof a procedure or a view:Given this, the MySQL auto-user deletion follows the same as the PostgreSQL one: it tries to drop the user and deactivates the user if it fails.