[v13] Allow Bots to submit access request reviews (#33375)#33510
Merged
strideynet merged 1 commit intobranch/v13from Oct 17, 2023
Merged
[v13] Allow Bots to submit access request reviews (#33375)#33510strideynet merged 1 commit intobranch/v13from
strideynet merged 1 commit intobranch/v13from
Conversation
* Guesstimate towards a solution * Remove unrelated comment * Roughly try a different way of supporting this * Revert line that was necessary to change * Change signature of exported func to match client * Fix test invocation * Add test for Bot reviewing access request * Fix missing err check in test * Use single context * Use client rather than unexported method in test * Check err before defer
rosstimothy
approved these changes
Oct 16, 2023
ravicious
approved these changes
Oct 17, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33375 to branch/v13