Gracefully handle web socket closure by clients#33480
Merged
rosstimothy merged 1 commit intomasterfrom Oct 16, 2023
Merged
Conversation
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
zmb3
approved these changes
Oct 14, 2023
Tener
approved these changes
Oct 16, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from r0mant
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Oct 16, 2023
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
rosstimothy
added a commit
that referenced
this pull request
Oct 16, 2023
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
rosstimothy
added a commit
that referenced
this pull request
Oct 16, 2023
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the terminal stream to detect when the web socket is closed by the UI via setting the close handler. This reduces the time it takes the server to know the client closed the connection from the value of the keep alive interval in the networking config (default 5m) to as soon as a user closes the tab. Prior to this any session that was terminated by closing the browser tab would have an active session tracker until the web socket ping loop, which runs at the keep alive interval, failed. Some logging was also cleaned up to reduce the amount of spam that appears as a result of a session being terminated by a user.
Changelog: Terminate web ssh sessions right away when a user closes the tab