Include 'nextAuditDate' in 'CreateAccessListReview' method#33479
Merged
Include 'nextAuditDate' in 'CreateAccessListReview' method#33479
Conversation
The 'CreateAccessListReview' method in the 'AccessListService' and 'Client' interfaces was altered to include the 'nextAuditDate'. The 'nextAuditDate' is now being collected during the review creation process and returned as a part of the result along with the created review.
jakule
commented
Oct 13, 2023
|
|
||
| // CreateAccessListReview will create a new review for an access list. | ||
| func (c *Client) CreateAccessListReview(ctx context.Context, review *accesslist.Review) (*accesslist.Review, error) { | ||
| func (c *Client) CreateAccessListReview(ctx context.Context, review *accesslist.Review) (*accesslist.Review, time.Time, error) { |
Contributor
Author
There was a problem hiding this comment.
@mdwn Do you know if this API has already been released?
Contributor
There was a problem hiding this comment.
It looks like it was in v14.0.3. The gRPC method for it didn't work then, however, so I'm unsure if we should concern ourselves too much with this.
mdwn
approved these changes
Oct 13, 2023
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
tigrato
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
tigrato
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'CreateAccessListReview' method in the 'AccessListService' and 'Client' interfaces was altered to include the 'nextAuditDate'. The 'nextAuditDate' is now being collected during the review creation process and returned as a part of the result along with the created review.