Dynamic Discovery Matchers for Databases#33472
Merged
marcoandredinis merged 1 commit intomasterfrom Oct 19, 2023
Merged
Conversation
marcoandredinis
added
discover
marcoandredinis
force-pushed
the
marco/discovery_dynamic_matchers
branch
2 times, most recently
from
eb70f49 to
651c53b
Compare
marcoandredinis
force-pushed
the
marco/discovery_dynamic_matchers
branch
3 times, most recently
from
ceee9d3 to
ca0fa50
Compare
github-actions
Bot
added
database-access
marcoandredinis
force-pushed
the
marco/discovery_dynamic_matchers
branch
from
ca0fa50 to
1971ccd
Compare
Contributor
Author
|
@lxea @ryanclark Friendly ping 🙏 |
marcoandredinis
force-pushed
the
marco/discovery_dynamic_matchers
branch
from
1971ccd to
2d47691
Compare
ryanclark
approved these changes
Oct 19, 2023
lxea
approved these changes
Oct 19, 2023
|
@marcoandredinis See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context #25494
The DiscoveryService monitors cloud/kube resources and merges them as Teleport resources.
It uses a static configuration that is present in the
discovery_servicesection of theteleport.yamlused by the teleport process.This PR adds a watcher to the
discovery_servicethat will monitor changes in DiscoveryConfig resources.Every time a new DiscoveryConfig is created/updated, the service will update its internal matchers to include those coming from the DiscoveryConfig.
When a DiscoveryConfig is deleted, the corresponding matchers are removed as well.
To reduce the scope, we are only focusing on the Database matchers.
Follow up PRs will include other resource types.
It always starts the Database Matcher, even if no static configuration exists.
When a new Poll (default is every 5 minutes) starts, it will iterate over all the fetchers:
discovery_servicefromteleport.yaml)