Manually sort pinned resources and UI fixes#33470
Conversation
There was a problem hiding this comment.
Why do we check this if in both cases we return false?
There was a problem hiding this comment.
I'm gonna accept this change as a stop-gap measure, but it sounds really strange and error-prone, especially security-wise, to do it like this. If we have a function that's called CanAccess on something that is called resourceChecker, we shouldn't expect the consumers of this function to understand that in a specific case of types.SAMLIdPServiceProvider, they should call something else. I think that this should be folded into either of these in the long term. Is there something I don't understand?
There was a problem hiding this comment.
Will add a TODO to fold SAML into this once I figure out why it wasn't there in the first place. Thanks
* Manually sort pinned resource requests and update match filter * Use Text component for not supported message
cd71b8a to
e5fe720
Compare
A couple small bug fixes found with pinned resources.
before
after