[v14] Show Connect My Computer button in empty state in Connect#33440
Merged
ravicious merged 1 commit intobranch/v14from Oct 13, 2023
Merged
[v14] Show Connect My Computer button in empty state in Connect#33440ravicious merged 1 commit intobranch/v14from
ravicious merged 1 commit intobranch/v14from
Conversation
* Reformat buttons story away from using spacing on individual elements * Add support for gap prop to Button * Fix and expand DocumentCluster stories * Add info about Discover to empty text in DocumentCluster * hasConnectMyComputerPermissions: Accept LoggedInUser instead of Cluster * Refactor getEmptyTableText into two separate functions This will make it easier to show the Connect My Computer button in the table with servers. * Show button for Connect My Computer in empty state * Show hint about adding resources on separate line * Do not show resources hint in leaf clusters
ryanclark
approved these changes
Oct 13, 2023
bl-nero
approved these changes
Oct 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33144.
The bot wasn't able to backport the PR cleanly because I forgot to rebase #33144 after it's base branch changed to master from #33142. #33142 was backported to v14 separately.