Conversation
…alancer in separate port mode
greedy52
commented
Oct 12, 2023
| Port: helpers.Port(t, suite.leaf.SSH), | ||
| ALBAddr: albProxy.Addr().String(), | ||
| }) | ||
| t.Run("WebProxyAddr behind ALB", func(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
Removed tc.testALPNConnUpgrade so tc.SSH is tested for all setups. In particular StandardAndOnePortSetupMasterALPNDisabled catches the case fixed by this change.
Renamed the subtest, and updated NewUnauthenticatedClienthelper in helpers.instance.go above. No other change to these tests.
rosstimothy
approved these changes
Oct 12, 2023
Joerger
approved these changes
Oct 12, 2023
public-teleport-github-review-bot
Bot
removed request for
smallinsky and
zmb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32531
When Proxy is in separate mode and web port is TLS-terminated by a load balancer,
tshtries to perform connection upgrades on SSH proxy address.This change disables connection upgrades if TLS routing is disabled when using the new proxy client.