Fix access list audit log formatting#33344
Merged
Conversation
gzdunek
approved these changes
Oct 12, 2023
| return str.substring(0, len - 3) + '...'; | ||
| } | ||
|
|
||
| function formattedMembersTxt(members: { member_name: string }[]) { |
Contributor
There was a problem hiding this comment.
A bit shorter option:
Suggested change
| function formattedMembersTxt(members: { member_name: string }[]) { | |
| function formatMembers(members: { member_name: string }[]) { |
| @@ -3062,6 +3062,7 @@ export const events = [ | |||
| updated_by: 'mike', | |||
Contributor
There was a problem hiding this comment.
Shouldn't we remove updated_by field from members in fixtures? RawEventAccessList.members doesn't contain it.
ravicious
approved these changes
Oct 12, 2023
Comment on lines
+1595
to
+1599
| if (memberNames.length > 1) { | ||
| return `members [${memberNamesJoined}]`; | ||
| } | ||
|
|
||
| return `member [${memberNamesJoined}]`; |
Member
There was a problem hiding this comment.
import { pluralize } from 'shared/utils/text';
Suggested change
| if (memberNames.length > 1) { | |
| return `members [${memberNamesJoined}]`; | |
| } | |
| return `member [${memberNamesJoined}]`; | |
| return `${pluralize(memberNames.length, "member")} [${memberNamesJoined}]` |
😎
Member
There was a problem hiding this comment.
Could you add a fixture with multiple members?
public-teleport-github-review-bot
Bot
removed the request for review
from mdwn
This was referenced Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from :
fixed:
