Skip to content

[v13] Refactor desktop event emission#33336

Merged
zmb3 merged 2 commits intobranch/v13from
zmb3/v13-backport-33189
Oct 13, 2023
Merged

[v13] Refactor desktop event emission#33336
zmb3 merged 2 commits intobranch/v13from
zmb3/v13-backport-33189

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Oct 11, 2023

Backports #33189

@zmb3 zmb3 changed the base branch from master to branch/v13 October 11, 2023 21:37
@zmb3 zmb3 changed the title Zmb3/v13 backport 33189 [v13] Refactor desktop event emission Oct 11, 2023
@github-actions github-actions Bot requested review from atburke and kimlisa October 11, 2023 21:38
@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented Oct 11, 2023

@ibeckermayer @rosstimothy @probakowski this was manual backport as the session recording is a bit different on v14. Appreciate a closer look at this one 🙏

@zmb3 zmb3 requested review from ibeckermayer, probakowski and rosstimothy and removed request for atburke, kimlisa, klizhentas, r0mant and russjones October 11, 2023 22:13
Copy link
Copy Markdown
Contributor

@ibeckermayer ibeckermayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'm not sure I accurately identified the manual pieces. I see recording happening here and here, are those the points of interest?

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from probakowski October 12, 2023 20:30
@zmb3 zmb3 enabled auto-merge October 13, 2023 00:27
@zmb3 zmb3 added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 13, 2023
@zmb3 zmb3 added this pull request to the merge queue Oct 13, 2023
Merged via the queue into branch/v13 with commit 86c16b7 Oct 13, 2023
@zmb3 zmb3 deleted the zmb3/v13-backport-33189 branch October 13, 2023 01:25
@camscale camscale mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants