Allow access requests to use user login state.#33317
Merged
Conversation
Access requests are now able to use the user login state as opposed to just the static user definition. This will allow access lists to influence who can review access requests.
mdwn
force-pushed
the
mike.wilson/access-requests-use-user-login-state
branch
from
c37ed0e to
1c09f9d
Compare
GavinFrazar
approved these changes
Oct 11, 2023
r0mant
approved these changes
Oct 11, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Fix lgtm but I think we should rethink this weird User vs UserState "dichotomy" we ended up with. It's very hard to reason about which one to use in which case now, plus how many other places are there we missed that still use User and won't get access list roles?
What can we do to fix this problem? Why can't we update the existing User object with something like "Status" calculated field that would be updated dynamically on login and contain user state? Then callers wouldn't need to worry about using wrong API.
public-teleport-github-review-bot
Bot
removed the request for review
from strideynet
This was referenced Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access requests are now able to use the user login state as opposed to just the static user definition. This will allow access lists to influence who can review access requests.