[v14] Refactor desktop audit event emission#33316
Merged
zmb3 merged 2 commits intobranch/v14from Oct 13, 2023
Merged
Conversation
Our methods for emitting audit events take 10 arguments already, and we need to add more as part of the work in #30417. To make this more manageable, create an auditor struct that will hold on to state that is shared for all audit events in a session (ID, user identity, the desktop we're connecting to, etc.) As a result, the "audit cache" for directory sharing events is also simplified - we now create one of these per-session rather than maintaining one large cache for all sessions.
github-actions
Bot
requested review from
ibeckermayer,
probakowski and
rosstimothy
ibeckermayer
approved these changes
Oct 11, 2023
rosstimothy
approved these changes
Oct 11, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33189 to branch/v14