[v14] Report exit code of rsync processes if they fail in TestWithRsync#33262
Merged
capnspacehook merged 3 commits intobranch/v14from Oct 11, 2023
Merged
[v14] Report exit code of rsync processes if they fail in TestWithRsync#33262capnspacehook merged 3 commits intobranch/v14from
capnspacehook merged 3 commits intobranch/v14from
Conversation
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-actions
Bot
added
backport
size/sm
tsh
zmb3
approved these changes
Oct 10, 2023
r0mant
approved these changes
Oct 10, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from lxea
Contributor
Author
|
Can I get an override for flaky test detector please, looks like it timed out |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
/excludeflake * |
lsgunn-teleport
pushed a commit
that referenced
this pull request
Oct 11, 2023
…nc (#33262) * report exit code of rsync processes if they fail * use correct 't' when asserting * Update tool/tsh/common/proxy_test.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33175 to branch/v14