Add Hardware Key login audit event fields#33254
Merged
Conversation
github-actions
Bot
added
application-access
database-access
r0mant
reviewed
Oct 10, 2023
Joerger
force-pushed
the
joerger/hardware-key-audit-events
branch
from
d98206f to
198769e
Compare
Joerger
added
backport/branch/v14
audit-log
ibeckermayer
approved these changes
Oct 13, 2023
Contributor
Author
|
@hugoShaka @r0mant Friendly reminder to review |
r0mant
reviewed
Oct 16, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Overall lgtm bar the proto field issue (unless it's the preferred way of doing things now).
Joerger
force-pushed
the
joerger/hardware-key-audit-events
branch
from
0acacd3 to
35e368e
Compare
Joerger
force-pushed
the
joerger/hardware-key-audit-events
branch
from
3385bf4 to
59b6383
Compare
r0mant
approved these changes
Oct 16, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from hugoShaka
* Clean up AuthenticateUser audit logic. * Fix proto field naming. * Fix merge conflict.
Joerger
force-pushed
the
joerger/hardware-key-audit-events
branch
from
d2167cc to
baaab08
Compare
Joerger
added a commit
that referenced
this pull request
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds audit event fields to track hardware key logins.
Audit log snippets:
{ "code": "T1000I", "ei": 0, "event": "user.login", "required_private_key_policy": "hardware_key_touch", }{ "code": "TC000I", "ei": 0, "event": "cert.create", "identity": { "private_key_policy": "hardware_key_touch", }, }{ "code": "T2006I", "event": "session.data", "private_key_policy": "hardware_key_touch", }