Prevent double registration of Kubernetes GVK for older Kube clusters#33253
Merged
Prevent double registration of Kubernetes GVK for older Kube clusters#33253
Conversation
Older Kubernetes clusters might have types that live outside of default Kubernetes types but are registered using different APIs. When Teleport starts, it tries to pull the resources from the cluster and panics because a certain type is already registered. This PR adds a check that prevents double registration. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
AntonAM
approved these changes
Oct 11, 2023
| @@ -0,0 +1,57 @@ | |||
| /* | |||
| Copyright 2022 Gravitational, Inc. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Copyright 2022 Gravitational, Inc. | |
| Copyright 2023 Gravitational, Inc. |
| arrayToPointerArray(o.Items), d.allowedResources, d.deniedResources, d.log), | ||
| ) | ||
| return len(o.Items) > 0, true, nil | ||
| case *extensionsv1beta1.Ingress: |
Contributor
There was a problem hiding this comment.
Should we maybe just join cases and enumerate types there? (separate for list ones and non-list ones)
GavinFrazar
approved these changes
Oct 11, 2023
strideynet
approved these changes
Oct 12, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older Kubernetes clusters might have types that live outside of default Kubernetes types but are registered using different APIs. When Teleport starts, it tries to pull the resources from the cluster and panics because a certain type is already registered.
This PR adds a check that prevents double registration.