AWS OIDC: Only consider Linux/UNIX when listing EC2 instances#33198
Merged
marcoandredinis merged 2 commits intomasterfrom Oct 16, 2023
Merged
AWS OIDC: Only consider Linux/UNIX when listing EC2 instances#33198marcoandredinis merged 2 commits intomasterfrom
marcoandredinis merged 2 commits intomasterfrom
Conversation
marcoandredinis
added
discover
zmb3
approved these changes
Oct 10, 2023
marcoandredinis
force-pushed
the
marco/list_ec2_filterout_windows
branch
from
aea21d6 to
a427f81
Compare
Contributor
Author
|
@gabrielcorado @smallinsky Friendly ping |
smallinsky
approved these changes
Oct 16, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from gabrielcorado
Listing EC2 instances is part of the EICE flow, where Teleport connects to the instance's SSH server. We were returning Windows instances, but those don't have an SSH Server, thus not compatible with the feature. This PR adds a new filter to only return Linux/UNIX instances.
marcoandredinis
force-pushed
the
marco/list_ec2_filterout_windows
branch
from
a427f81 to
15798e3
Compare
|
@marcoandredinis See the table below for backport results.
|
This was referenced Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listing EC2 instances is part of the EICE flow, where Teleport connects to the instance's SSH server.
We were returning Windows instances, but those don't have an SSH Server, thus not compatible with the feature.
This PR adds a new filter to only return Linux/UNIX instances.
Before
After
