Properly check for SAMLIdPServiceProvider access#33190
Merged
Conversation
kimlisa
reviewed
Oct 10, 2023
kimlisa
reviewed
Oct 10, 2023
codingllama
approved these changes
Oct 10, 2023
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| names := []string{"vivi", "cloud", "aerith", "baret", "cid", "vivi2"} | |
| names := []string{"vivi", "cloud", "aerith", "barret", "cid", "vivi2"} |
;)
kimlisa
approved these changes
Oct 10, 2023
Contributor
There was a problem hiding this comment.
looks like this logging is deferred until the end, wouldn't ListUnifiedResources(%v->%v) be the same? b/c they both refer to the same resources, should it be 0 -> len(unifiedResources)?
Contributor
Author
There was a problem hiding this comment.
yeah. i actually don't think we need this anymore anyway. it was left over from when we pulled in every resource and then filtered down. so it was valuable to see how long it took to fetch and filter through all those. I can remove it completely now that we only iterate.
I have a PR in flight that will cause a merge conflict here so when its finished in the merge queue, i'll fix the conflict and clean up this function
avatus
force-pushed
the
avatus/unified_saml_access_check
branch
from
fed67e0 to
b75b242
Compare
avatus
added a commit
that referenced
this pull request
Oct 11, 2023
* Properly check for SAMLIdPServiceProvider access * Remove unneeded debug log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I added sort indexes to the unified resource cache I consolidated all the access checks because they are all the same... EXCEPT for SAML apps that I forgot about. This means they are excluded from the unified web UI atm. This fix changes it. I updated one of the tests to make sure SAML show up just in case I miss some weird edge case again