[v14] fix leaf SSH sessions not getting recorded#33102
Merged
capnspacehook merged 1 commit intobranch/v14from Oct 9, 2023
Merged
[v14] fix leaf SSH sessions not getting recorded#33102capnspacehook merged 1 commit intobranch/v14from
capnspacehook merged 1 commit intobranch/v14from
Conversation
capnspacehook
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
capnspacehook
force-pushed
the
capnspacehook/backport/v14/32163
branch
from
64a7781 to
3ce0701
Compare
* fix leaf SSH sessions not getting recorded * add integration test * address feedback, overhaul integration test * make each test case use fresh clusters to fix failing case * address feedback * Apply suggestions from code review Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * fix integration test failures --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
capnspacehook
force-pushed
the
capnspacehook/backport/v14/32163
branch
from
3ce0701 to
9ff3b98
Compare
jakule
approved these changes
Oct 9, 2023
AntonAM
approved these changes
Oct 9, 2023
public-teleport-github-review-bot
Bot
removed request for
camscale and
rosstimothy
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32163.
Not a clean backport, but the only new change is fixing
withProxyRecordingMode's function signature inintegration_test.go.