Make system roles case-insensitive in provision tokens#33053
Merged
Conversation
AntonAM
approved these changes
Oct 5, 2023
Contributor
There was a problem hiding this comment.
As I understand that's just not to have an error for ease of usage and idea is it will error out upper?
Collaborator
|
Can we reuse some of the parsing code added in #9756? This seems duplicative |
jakule
approved these changes
Oct 7, 2023
This change makes system roles set in a provision token case-insensitive.
atburke
force-pushed
the
atburke/token-role-case
branch
from
ad79e19 to
fbb720c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes system roles set in a provision token case-insensitive.
Resolves #30768.