Merged
Conversation
zmb3
force-pushed
the
zmb3/desktop-usage-metrics
branch
from
20ab1ce to
c068b2b
Compare
zmb3
force-pushed
the
zmb3/desktop-usage-metrics
branch
3 times, most recently
from
162dd96 to
c357f2f
Compare
zmb3
force-pushed
the
zmb3/desktop-usage-metrics
branch
from
c357f2f to
e6ea120
Compare
ravicious
approved these changes
Oct 12, 2023
| DesktopDirectoryShare: &prehogv1a.DesktopDirectoryShareEvent{ | ||
| Desktop: a.AnonymizeString(e.Desktop), | ||
| UserName: a.AnonymizeString(e.UserName), | ||
| DirectoryName: a.AnonymizeString(e.DirectoryName), |
Member
There was a problem hiding this comment.
Why do we capture DirectoryName? Is this to see if people share the same dir over and over or use folder sharing for different folders?
Collaborator
Author
There was a problem hiding this comment.
Yes. The combination of directory, desktop, and user can give us insight into usage patterns. (How many different unique directories, does each user share many directories or always the same one, etc)
rudream
approved these changes
Oct 12, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30417