Skip to content

Downgrade Electron to 25.9.0#33011

Merged
gzdunek merged 1 commit intomasterfrom
ravicious/downgrade-electron
Oct 6, 2023
Merged

Downgrade Electron to 25.9.0#33011
gzdunek merged 1 commit intomasterfrom
ravicious/downgrade-electron

Conversation

@ravicious
Copy link
Copy Markdown
Member

@ravicious ravicious commented Oct 5, 2023

This should take care of #32832 caused by electron/electron#39775 in Electron 26.

25.9.0 is supported until January 2024 and fixes several CVEs compared to 25.1.1 that we were using before the update to 26.

Changelog: Fixed a blank screen in Teleport Connect sometimes occurring on Linux.

@ravicious
Copy link
Copy Markdown
Member Author

ravicious commented Oct 5, 2023

I'm going to start a tag build off v14 to verify that it helps with the blank screen.

https://drone.platform.teleport.sh/gravitational/teleport/29295

@ravicious
Copy link
Copy Markdown
Member Author

@jentfoo You no longer need to take care of the Electron update. ;)

@ravicious ravicious removed the request for review from ibeckermayer October 5, 2023 11:10
Copy link
Copy Markdown
Contributor

@gzdunek gzdunek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a preemptive approval

@ravicious
Copy link
Copy Markdown
Member Author

The build pipeline is super unstable today, this is my last attempt for today:

https://drone.platform.teleport.sh/gravitational/teleport/29312

Copy link
Copy Markdown
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravicious Tested locally, works fine on Ubuntu 22.04 with Wayland enabled.

@gzdunek
Copy link
Copy Markdown
Contributor

gzdunek commented Oct 6, 2023

Tested on macOS and Windows.

@gzdunek gzdunek added this pull request to the merge queue Oct 6, 2023
Merged via the queue into master with commit a26e4b0 Oct 6, 2023
@gzdunek gzdunek deleted the ravicious/downgrade-electron branch October 6, 2023 09:41
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ravicious See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants