[v13] removeSecure() should close the file before removing it on Windows#32964
Merged
gzdunek merged 2 commits intobranch/v13from Oct 4, 2023
Merged
[v13] removeSecure() should close the file before removing it on Windows#32964gzdunek merged 2 commits intobranch/v13from
removeSecure() should close the file before removing it on Windows#32964gzdunek merged 2 commits intobranch/v13from
Conversation
zmb3
approved these changes
Oct 4, 2023
espadolini
approved these changes
Oct 4, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from jentfoo
jentfoo
approved these changes
Oct 4, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #32948 to branch/v13
Changelog: Fixed issue causing keys to be incorrectly removed in tsh and Teleport Connect on Windows.