Skip to content

Extend HandshakeReadDeadline for hardware key signatures with pin/touch#32921

Merged
Joerger merged 4 commits intomasterfrom
joerger/fix-tls-timeout
Oct 9, 2023
Merged

Extend HandshakeReadDeadline for hardware key signatures with pin/touch#32921
Joerger merged 4 commits intomasterfrom
joerger/fix-tls-timeout

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Oct 3, 2023

Extend handshake read deadline to allow signature operations that require user input to be completed (hardware key touch/pin).

Fixes:

> tsh ls
Tap your YubiKey
# wait 5 seconds
ERROR: connection error: desc = "transport: failed to write client preface: write tcp 127.0.0.1:60602->127.0.0.1:3080: write: broken pipe"

…uire user input to be completed (hardware key touch/pin).
@Joerger Joerger force-pushed the joerger/fix-tls-timeout branch from 83fad0e to e693627 Compare October 3, 2023 20:47
@Joerger Joerger enabled auto-merge October 3, 2023 20:57
@Joerger Joerger added this pull request to the merge queue Oct 9, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2023
@Joerger Joerger added this pull request to the merge queue Oct 9, 2023
Merged via the queue into master with commit 5b850c9 Oct 9, 2023
@Joerger Joerger deleted the joerger/fix-tls-timeout branch October 9, 2023 19:34
Joerger added a commit that referenced this pull request Oct 12, 2023
…uire user input to be completed (hardware key touch/pin). (#32921)
github-merge-queue Bot pushed a commit that referenced this pull request Oct 14, 2023
…uire user input to be completed (hardware key touch/pin). (#32921) (#33348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants