[Web] Allow Security Group selection in AWS RDS Discovery flow#32885
Merged
[Web] Allow Security Group selection in AWS RDS Discovery flow#32885
Conversation
kimlisa
reviewed
Oct 3, 2023
Contributor
|
I would change the DeployService part to have its own step |
kimlisa
approved these changes
Oct 5, 2023
Contributor
|
I tested this manually and it LGTM |
gzdunek
reviewed
Oct 6, 2023
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Sorry for the late review, a few comments from me.
rudream
force-pushed
the
yassine/deployservice-securitygroups
branch
from
c87d252 to
68b29ef
Compare
gzdunek
approved these changes
Oct 12, 2023
rudream
force-pushed
the
yassine/deployservice-securitygroups
branch
from
68b29ef to
5ac85e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #30622
This PR adds an optional AWS security group picker to the
DeployServicestep of the RDS Discover flow.Demo