Prevent Kube proxy from set the default Kube impersonation headers#32839
Merged
Prevent Kube proxy from set the default Kube impersonation headers#32839
Conversation
This PR removes the ability of the Kubernetes Proxy to set the default values of Kubernetes Impersonation headers. This task is delegated to the kubernetes_service or kubernetes legacy proxy that handles the request. This is required because under certain contiditons it might have requests that failed because the values were improperly defined. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
strideynet
approved these changes
Oct 2, 2023
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Looks good - thanks for including test cases.
AntonAM
approved these changes
Oct 2, 2023
public-teleport-github-review-bot
Bot
removed request for
gabrielcorado and
ryanclark
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the ability of the Kubernetes Proxy to set the default values of Kubernetes Impersonation headers. This task is delegated to the kubernetes_service or kubernetes legacy proxy that handles the request.
This is required because under certain contiditons it might have requests that failed because the values were improperly defined.