pgbk: remove CREATE PUBLICATION#32464
Merged
espadolini merged 1 commit intomasterfrom Sep 25, 2023
Merged
Conversation
espadolini
force-pushed
the
espadolini/pgbk-remove-create-publication
branch
from
67c3597 to
1abbd7a
Compare
EdwardDowling
approved these changes
Sep 25, 2023
mdwn
approved these changes
Sep 25, 2023
strideynet
approved these changes
Sep 25, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rosstimothy
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@espadolini See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing
CREATE PUBLICATIONactually requires create permissions over the database rather than just the schema that contains thekvtable, so it's technically a breaking change if the database user only has privileges over a schema (see #32197, which was prompted by a customer that restricts the database user to a specific schema).It's harmless to remove the line, as the
kv_pubpublication is not currently used anywhere and it was only added to more easily support the use ofpgoutputin the future. A note was left in its stead, so we don't accidentally try to blindly create the publication again.