allow teleport to start when some etcd nodes are unreachable#32438
Merged
fspmarshall merged 2 commits intomasterfrom Sep 28, 2023
Merged
allow teleport to start when some etcd nodes are unreachable#32438fspmarshall merged 2 commits intomasterfrom
fspmarshall merged 2 commits intomasterfrom
Conversation
zmb3
reviewed
Sep 23, 2023
| // wait for results | ||
| var err error | ||
| for range b.cfg.Nodes { | ||
| err = <-results |
Collaborator
There was a problem hiding this comment.
Should we select over both results and ctx.Done() here?
Contributor
Author
There was a problem hiding this comment.
this is blocking on an operation that is scoped to ctx, so I don't think it adds anything.
fspmarshall
force-pushed
the
fspmarshall/fix-etcd-check
branch
2 times, most recently
from
638942c to
6c78046
Compare
fspmarshall
force-pushed
the
fspmarshall/fix-etcd-check
branch
from
0d0c2c6 to
45c5d09
Compare
fspmarshall
changed the title
zmb3
approved these changes
Sep 28, 2023
rosstimothy
approved these changes
Sep 28, 2023
public-teleport-github-review-bot
Bot
removed request for
gzdunek and
probakowski
|
@fspmarshall See the table below for backport results.
|
This was referenced Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the etcd backend to start if any endpoint is reachable rather than only starting if all endpoints are reachable.
Fixes #23516