Skip to content

docs: Reorganize and revise moderated sessions#32420

Merged
lsgunn-teleport merged 17 commits intomasterfrom
LG/moderated-sessions-revision
Oct 12, 2023
Merged

docs: Reorganize and revise moderated sessions#32420
lsgunn-teleport merged 17 commits intomasterfrom
LG/moderated-sessions-revision

Conversation

@lsgunn-teleport
Copy link
Copy Markdown
Contributor

@lsgunn-teleport lsgunn-teleport commented Sep 22, 2023

Related to the change in #32357.
Reorganized to more clearly delineate configuring "require" policies and fields and configuring "allow" policies and fields.
Removed some redundant information.
Moved descriptions of fields to where they seemed most relevant.
Removed backward compatibility chunk for v4 roles (not planning to backport this beyond v14, per se).
Updated the links to sections where headings changed.
Updated voice, tense, and PoV.

@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel September 22, 2023 19:51 — with GitHub Actions Inactive
@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel September 22, 2023 19:59 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-chce74fcq-goteleport.vercel.app/docs/ver/14.x

@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel September 22, 2023 20:16 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-oxsbp9sli-goteleport.vercel.app/docs/ver/14.x

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-cnzj7zcnw-goteleport.vercel.app/docs/ver/14.x

@ptgott
Copy link
Copy Markdown
Contributor

ptgott commented Sep 25, 2023

@lsgunn-teleport To help with reviews, would you mind summarizing why this PR makes these changes, including any GitHub issues it addresses?

Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
You should note that users who are assigned a role with a `join_sessions` allow policy are
implicitly allowed to list sessions. In most cases, `deny` statements take precedent.
However, if the `join_sessions` policy is set in a role, the `join_sessions` policy
overrides any explicit deny setting for listing sessions.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion on your other PR, we need to clarify this behavior before we update the docs.

### Require policy count
If you join a session with `tsh join` or `tsh kube join`, you can specify a
participant mode with the `--mode <mode>` command-line option, where `<mode>` is `peer`,
`moderator`, or `observer`. The default participant mode is `observer`.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do note that defaulting to observer is a relatively recent change, so be careful when backporting this. (Off the top of my head, I think it only applies to v13 and up)

Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel September 27, 2023 17:53 — with GitHub Actions Inactive
@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel September 27, 2023 17:53 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-14wfs5e3k-goteleport.vercel.app/docs/ver/14.x

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-kcssk7z8h-goteleport.vercel.app/docs/ver/14.x

@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel October 9, 2023 17:48 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2023

🤖 Vercel preview here: https://docs-elhg795l4-goteleport.vercel.app/docs/ver/preview

@lsgunn-teleport lsgunn-teleport requested a review from zmb3 October 10, 2023 18:25
@lsgunn-teleport
Copy link
Copy Markdown
Contributor Author

@xinding33 Can you take a look at this PR? It's been hanging around a while waiting for #32357.

@lsgunn-teleport lsgunn-teleport temporarily deployed to vercel October 10, 2023 18:27 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-5bhwa5oao-goteleport.vercel.app/docs/ver/preview

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from r0mant October 11, 2023 23:02
@lsgunn-teleport lsgunn-teleport added this pull request to the merge queue Oct 12, 2023
Merged via the queue into master with commit 33b2ae6 Oct 12, 2023
@lsgunn-teleport lsgunn-teleport deleted the LG/moderated-sessions-revision branch October 12, 2023 18:22
@public-teleport-github-review-bot
Copy link
Copy Markdown

@lsgunn-teleport See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed

@ptgott
Copy link
Copy Markdown
Contributor

ptgott commented Oct 16, 2023

Hi @lsgunn-teleport, just checking whether we have a plan to backport this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clarify creating moderated sessions for leaf nodes

4 participants