Fix repeated installation for Azure and GCP VM auto-discovery#32361
Merged
Fix repeated installation for Azure and GCP VM auto-discovery#32361
Conversation
zmb3
approved these changes
Sep 25, 2023
tcsc
reviewed
Sep 26, 2023
| // won't run them more than once. This is fine when the installer script | ||
| // succeeds, but it makes troubleshooting much harder when it fails. To | ||
| // work around this, we generate a random string and append it as a comment | ||
| // to the script, forcing Azure to see each invocation as unique. |
tcsc
approved these changes
Sep 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
This was referenced Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the keys of labels applied to discovered Azure and GCP VMs did not match the labels the Discovery Service expected, causing the Discovery Service to try to install them again.
This PR also adds a workaround for an Azure quirk where Azure would not run the same command more than once.
Fixes #28879.