Skip to content

[Access Monitoring] Add nav title & packages#32299

Merged
ryanclark merged 1 commit intomasterfrom
ryan/access-monitoring
Oct 16, 2023
Merged

[Access Monitoring] Add nav title & packages#32299
ryanclark merged 1 commit intomasterfrom
ryan/access-monitoring

Conversation

@ryanclark
Copy link
Copy Markdown
Member

Adds the packages needed for the bar charts and query editor in Access Monitoring.

Also adds the nav title.

Comment thread web/packages/shared/package.json Outdated
Comment on lines +13 to +23
"@codemirror/lang-sql": "^6.5.2",
"@nivo/bar": "^0.83.0",
"@react-spring/web": "^9.7.2",
"@uiw/codemirror-theme-dracula": "^4.21.9",
"@uiw/react-codemirror": "^4.21.9",
"@use-gesture/react": "^10.2.27",
"ace-builds": "1.4.6",
"create-react-class": "^15.6.3",
"cross-env": "5.0.5",
"d3-time-format": "^4.1.0",
"d3-scale": "^4.0.2",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these go here or in e-imports? I imagine we'll probably end up using CodeMirror and graphs in OSS at some point, but I'm fine to move it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if these are used only in the enterprise version, I would move them to e-imports.

@ryanclark ryanclark force-pushed the ryan/access-monitoring branch from 5ba531d to a6a218d Compare October 13, 2023 12:43
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ryanclark - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@ryanclark ryanclark force-pushed the ryan/access-monitoring branch 2 times, most recently from 1006b1f to da59fd4 Compare October 13, 2023 15:26
Comment thread web/packages/teleport/src/types.ts Outdated
// Access Management
Users = 'Users',
Roles = 'User Roles',
AccessMonitoring = 'Access Monitoring',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanclark btw, access monitoring needs to go under the new section i just merged Identity Governance & Security line 60

@ryanclark ryanclark force-pushed the ryan/access-monitoring branch from d148cf6 to 3f54040 Compare October 16, 2023 10:34
@ryanclark ryanclark added this pull request to the merge queue Oct 16, 2023
Merged via the queue into master with commit bc88bc2 Oct 16, 2023
@ryanclark ryanclark deleted the ryan/access-monitoring branch October 16, 2023 10:56
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ryanclark See the table below for backport results.

Branch Result
branch/v14 Create PR

Comment on lines +8 to +14
"@nivo/bar": "^0.83.0",
"@stripe/react-stripe-js": "^1.16.5",
"@stripe/stripe-js": "^1.48.0"
"@stripe/stripe-js": "^1.48.0",
"@uiw/codemirror-themes": "^4.21.20",
"@uiw/react-codemirror": "^4.21.20",
"d3-time-format": "^4.1.0",
"d3-scale": "^4.0.2",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can update @nivo/bar and d3-scale to get rid of the vuln alert for d3-color?

https://github.com/gravitational/teleport/security/dependabot/211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants