[v14] Implement waiting for Connect My Computer node to join cluster#32295
Merged
ravicious merged 1 commit intobranch/v14from Sep 21, 2023
Merged
[v14] Implement waiting for Connect My Computer node to join cluster#32295ravicious merged 1 commit intobranch/v14from
ravicious merged 1 commit intobranch/v14from
Conversation
* Add daemon.Service.ResolveClusterURI * Accept agents dir through command line flag tshd needs to know this out of band, so that when the Electron app tells it to watch for host UUID file for a specific cluster, the Electron app can send just the profile name of the cluster instead of an arbitrary path on the computer. * Implement WaitForConnectMyComputerNodeJoin in tsh daemon * wait: Use addEventListener instead of onabort * Make TshAbortController emit abort event only once This aligns it with a regular AbortController, which also emits the event only once. * Refactor how types are imported in tshd fixtures * Implement WaitForConnectMyComputerNodeJoin in Electron app * createAbortController: Add signal.aborted, use emitter.once * Improve wait function based on Deno implementation https://github.com/denoland/deno_std/blob/72d6e6641e3cd39ae69fba89a78feab354018ef0/async/delay.ts#L39 * Add a comment about the events package
github-actions
Bot
added
backport
size/lg
tsh
gzdunek
approved these changes
Sep 21, 2023
avatus
approved these changes
Sep 21, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30905.
master includes one test that isn't present on v14, so the diff has one less line where I had to add
AgentsDir: t.TempDir(),.