[v13] Define and add IneligibleStatus fields for access list members and owners (#31857)#32279
Merged
kimlisa merged 3 commits intobranch/v13from Sep 21, 2023
Merged
[v13] Define and add IneligibleStatus fields for access list members and owners (#31857)#32279kimlisa merged 3 commits intobranch/v13from
IneligibleStatus fields for access list members and owners (#31857)#32279kimlisa merged 3 commits intobranch/v13from
Conversation
kimlisa
changed the title
IneligibleStatus fields for access list members and owners (#31857)IneligibleStatus fields for access list members and owners (#31857)
mdwn
approved these changes
Sep 21, 2023
jakule
approved these changes
Sep 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport (#31857) to branch/v13
manual backport because of a conflict with how we return error.
in
masterwe returntrace.Wrap(err)fromconv.FromProto, but inv13we returntrail.FromGRPC(err)(i went withtrace.Wrap(err)b/c conv.FromProto returns trace errors)also adds a fix where i didn't check error before running options: 50ee88c