Client check for YubiKey private key touch/pin policies#32264
Merged
Client check for YubiKey private key touch/pin policies#32264
Conversation
This was referenced Sep 20, 2023
Joerger
force-pushed
the
joerger/piv-client-side-attestation
branch
3 times, most recently
from
b20b6bf to
e39ac0b
Compare
Joerger
force-pushed
the
joerger/piv-client-side-attestation
branch
from
97d3f06 to
550cf20
Compare
Contributor
Author
r0mant
approved these changes
Sep 28, 2023
atburke
approved these changes
Sep 28, 2023
Joerger
added a commit
that referenced
this pull request
Oct 12, 2023
* Preemptively check yubikey private key touch/pin policies on the client side. * Replace hardware key signer functions with private key methods. * Refactor overwrite/generate key logic.
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Refactor PIV metadata certificate logic (#32250) * Change PIV metadata cert to be self signed by an ephemeral key so it can be signed without touch/pin. * Refactor touch prompt logic. * Prompt user before overwriting non-teleport certificates instead of just returning an error. * Update RFD and Docs. * Address CR. * Export some methods and variables for use in tests. * Address comments. * Make Hardware Key unit test interactive (#32235) * Make yubikey unit test interactive and add to test plan. * Move yubikey hardware signer method tests to interactive yubikey test. * Remove hardware key interactive unit test from testplan * Client check for YubiKey private key touch/pin policies (#32264) * Preemptively check yubikey private key touch/pin policies on the client side. * Replace hardware key signer functions with private key methods. * Refactor overwrite/generate key logic. * Have hardware_key_touch count towards MFA verification instead of replacing the normal MFA verification flow. (#31663)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preemptively check YubiKey private key touch/pin policies on the client side.
Reviewing commit by commit should be easier, as the last commit is mostly refactors.
Prerequisite for #31732