Validate SAMLIdPServiceProviders ACS endpoints#32218
Merged
rosstimothy merged 1 commit intomasterfrom Sep 20, 2023
Merged
Conversation
r0mant
approved these changes
Sep 20, 2023
Tener
approved these changes
Sep 20, 2023
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
Should we allow existing ones? We could validate and possibly return an error when Getting or Listing
public-teleport-github-review-bot
Bot
removed the request for review
from strideynet
Enforces that all ACS endpoints are HTTPS to prevent any XSS attacks. To allow admins to interogate any existing resources which may be impacted validation only happens on create and update but not get. All usages of SAMLIdPServiceProviders within teleport follow all internal retrievals with a call to services.ValidateAssertionConsumerServicesEndpoint in order to subvert invalid ACS endpoints.
rosstimothy
force-pushed
the
tross/saml_acs
branch
from
b54cda2 to
e70a6a7
Compare
marcoandredinis
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforces that all ACS endpoints are HTTPS to prevent any XSS attacks. To allow admins to interogate any existing resources which may be impacted validation only happens on create and update but not get. All usages of SAMLIdPServiceProviders within teleport follow all internal retrievals with a call to
services.ValidateAssertionConsumerServicesEndpoint in order to subvert invalid ACS endpoints.