Add Access List usage events, emit event for userloginstate Generator.#32196
Merged
Add Access List usage events, emit event for userloginstate Generator.#32196
Conversation
Contributor
Author
|
It looks like I've missed a few things w/r/t prehog here, so I need to add these in. I'll ping once these are finished. |
Contributor
Author
zmb3
reviewed
Sep 20, 2023
zmb3
reviewed
Sep 20, 2023
avatus
approved these changes
Sep 20, 2023
Joerger
approved these changes
Sep 21, 2023
Access List usage events have been added, counting create and delete for Access Lists and Access List members. Additionally, an event for granting Access List access to users has been added to the userloginstate Generator and is now tested for.
mdwn
force-pushed
the
mike.wilson/add-access-list-posthog-events
branch
from
8137d83 to
638ba0f
Compare
This was referenced Sep 21, 2023
Contributor
|
There's not even a PR merged for this in cloud, so we just narrowly avoided a conflict in the protobuf definition, and the events generated here are just going to end up as errors in the ingest service's logs, because they're just parsed as unknown fields in the message. We should revert the v13 and v14 backports until we fix that. edit: we just pushed forward and got the cloud side of things merged, so we can hold off on reverting the backports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access List usage events have been added, counting create and delete for Access Lists and Access List members. Additionally, an event for granting Access List access to users has been added to the userloginstate Generator and is now tested for.
Note: I haven't actually tested this yet, I'm still trying to figure out how to do this, or if it's possible.