[v14]: Error and retry support for infinite scroll#32130
Merged
zmb3 merged 1 commit intobranch/v14from Sep 19, 2023
Merged
Conversation
* Add some unit tests to the existing useInfiniteScroll hook * Change the interface of the infinite scroll hook Now it only exposes one fetch function that can be used to trigger fetches from infinite scroll, regardless of whether it's the initial or a subsequent fetch. Restarting the data stream is driven by changing filtering parameters. * Harden useKeyBasedPagination * Install jsdom-testing-mocks * Error and retry support for infinite scroll * Fix type-check * Fix a state management bug * Make useInfiniteScroll a wrapper over useKeyBasedPagination * Get rid of unnecessary useEffect * Address review comments * Layout fixes * Review * Lint fix * Add the license * One more review round * Tweak the comment in useInfiniteScroll Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com> --------- Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com>
github-actions
Bot
requested review from
avatus,
ibeckermayer,
kimlisa and
ravicious
ravicious
approved these changes
Sep 19, 2023
zmb3
approved these changes
Sep 19, 2023
public-teleport-github-review-bot
Bot
removed request for
avatus,
ibeckermayer and
kimlisa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #30964
This merge was requested because of conflicts on the
Resources.tsxfile, but somehow, it managed to merge automatically on my machine. Perhapsgit rererehad something to do with it. Anyway, no manual tweaks were required.