Allow port forwarding to be disabled. #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the option for port forwarding is not specified, it's enabled by default. Port forwarding is not specified in the default-implicit-role. Since it's included in all role sets, port forwarding is always enabled for all roles. To fix this, port forwarding in the default-implicit-role is set to false.
fspmarshall
approved these changes
Dec 13, 2019
|
@fspmarshall Unfortunately this change won't limit default behavior. That's what the previous #3207 PR did, but I backed it out in-favor of this PR for the exact reason you said: it would break Teleport for people that had left port forwarding unspecified in their role. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the option for port forwarding is not specified, it's enabled by default. Port forwarding is not specified in the
default-implicit-role. Since it's included in all role sets, port forwarding is always enabled for all roles.To fix this, port forwarding in the
default-implicit-roleis set to false.