Conversation
| const handleSelectAll = () => { | ||
| setKinds(kindOptions.map(k => k.value)); | ||
| }; | ||
|
|
||
| const handleClearAll = () => { | ||
| setKinds([]); | ||
| }; | ||
|
|
There was a problem hiding this comment.
These methods seem a bit simple atm, but when we start to add more filter types besides just kinds they will grow a bit.
| onClick={handleOpen} | ||
| > | ||
| Type | ||
| Types {kindsFromParams.length > 0 ? `(${kindsFromParams.length})` : ''} |
There was a problem hiding this comment.
Similarly, this will change once we add more filters but abstracting now seemed a bit frivolous
| } | ||
|
|
||
| return stringCompare(nameA, nameB, isDesc) | ||
| return stringCompare(strings.ToLower(nameA), strings.ToLower(nameB), isDesc) |
There was a problem hiding this comment.
Good idea. I believe I have the test testing what we want 91cb348
There was a problem hiding this comment.
i wanted to test this change out in storybook, but i think most of it got broken along the way. doesn't seem like this PR would've broke it, or am i missing something? (i saw these stories in working state like couple weeks ago)
There was a problem hiding this comment.
Storybook is working for me. What errors are you seeing?
There was a problem hiding this comment.
weird, i tried it again (404)
There was a problem hiding this comment.
Ah, I believe that is related to changes made here #30964
There was a problem hiding this comment.
Hmmm... Folks, I don't want to sound cliche, but it works for me. :D
There was a problem hiding this comment.
Holy cow, I think I know what the issue is. I just noticed that you are using your machine's explicit IP address, and I was always using 127.0.0.1 instead. If I substitute my machine's IP, it ends up on 404, too. It looks like that mock service worker Storybook plugin fails to load resources with a different IP. I'll take a look and see if it can be configured another way, since I'd really like to avoid moving away from it (it was the only way I could get both API calls and SVG loading to work). In the meantime, please use 127.0.0.1.
There was a problem hiding this comment.
I don't really know how to fix it. :( It might be related to security restrictions (apparently, service workers are not allowed for pages not running on HTTPS if they're not accessed using localhost URLs). The mystery is why then other tests work, so I'm more inclined to believe that this is plugin-specific (other tests use MSW directly). I have a more important thing to do at the moment (backporting that PR mentioned above), but perhaps I'll give it one more try in the afternoon. Perhaps upgrading Storybook will change something; the version we're using is a bit old and ratchety.
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
ravicious
* Remove old indicator from unified resources * Use lowercase for unified name sort * Include friendly name in app icon guess * Add filters exist indicator * Remove uppercase from filter buttons and add filter count * Remove indicator import * Resource custom sort by contained resource * Add unified name compare test
* Remove old indicator from unified resources * Use lowercase for unified name sort * Include friendly name in app icon guess * Add filters exist indicator * Remove uppercase from filter buttons and add filter count * Remove indicator import * Resource custom sort by contained resource * Add unified name compare test
5 participants
This PR is a collection of a few fixes
Sort alphabetically regardless of case
Removes the old spinning indicator at the bottom of the unified resources list
Includes friendly name in the app icon guess
adds Select All/Clear All buttons to the type filter menu, as well as a selected filter count and indiciator
