Skip to content

DiscoveryConfig: add proto and gRPC methods#32035

Merged
marcoandredinis merged 4 commits intomasterfrom
marco/discovery_resource_proto
Sep 21, 2023
Merged

DiscoveryConfig: add proto and gRPC methods#32035
marcoandredinis merged 4 commits intomasterfrom
marco/discovery_resource_proto

Conversation

@marcoandredinis
Copy link
Copy Markdown
Contributor

RFD: https://github.com/gravitational/teleport/blob/master/rfd/0125-dynamic-auto-discovery-config.md
Context: #25494

This PR adds the required Proto Service to manage DiscoveryConfig resources.

@marcoandredinis marcoandredinis added discover Issues related to Teleport Discover backport/branch/v14 labels Sep 18, 2023
@marcoandredinis marcoandredinis force-pushed the marco/discovery_resource_proto branch from aa146ce to 79a8f55 Compare September 18, 2023 10:52
Comment thread api/proto/teleport/discoveryconfig/v1/discoveryconfig_service.proto Outdated
@marcoandredinis marcoandredinis force-pushed the marco/discovery_resource_proto branch from df677ce to e013e32 Compare September 20, 2023 16:34
Copy link
Copy Markdown
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments to docs

Comment thread api/proto/teleport/discoveryconfig/v1/discoveryconfig.proto Outdated
Comment thread api/proto/teleport/discoveryconfig/v1/discoveryconfig.proto Outdated
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from rudream September 21, 2023 14:52
Adds a new resource: DiscoveryConfig.
It also adds the CRUD methods over that resource.
Implementation will follow.
@marcoandredinis marcoandredinis force-pushed the marco/discovery_resource_proto branch from 8c88502 to 4b435a4 Compare September 21, 2023 14:57
@marcoandredinis marcoandredinis added this pull request to the merge queue Sep 21, 2023
Merged via the queue into master with commit 61233cd Sep 21, 2023
@marcoandredinis marcoandredinis deleted the marco/discovery_resource_proto branch September 21, 2023 15:34
@public-teleport-github-review-bot
Copy link
Copy Markdown

@marcoandredinis See the table below for backport results.

Branch Result
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discover Issues related to Teleport Discover size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants