[v14] Careful handling when loading files#31958
Merged
jentfoo merged 16 commits intobranch/v14from Sep 15, 2023
Merged
Conversation
This commit attempts to provide a common API so that the decision of when to follow symlinks is a conscious decision. Because Teleport (particularly the agent) runs in a privilege context, there is risk that following symlinks may allow information disclosure. After review of the cases covered in this commit (and some additional cases where this API was not a natural fit), this does not appear to be a broad problem. This commit however does fix the one known flaw described in the issue https://github.com/gravitational/teleport-private/issues/1009
Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com>
After PR discussion it was highlighted that MacOS does not guard against hardlinks in the same way linux does. For that reason this implementation has been updated with OS conditional logic to validate against hardlinks.
Make hardlink count lookup code build conditional to avoid undefined syscall.Stat_t.
jentfoo
requested review from
Tener,
codingllama,
r0mant,
timothyb89 and
zmb3
github-actions
Bot
added
backport
machine-id
size/md
tctl
r0mant
approved these changes
Sep 15, 2023
zmb3
approved these changes
Sep 15, 2023
public-teleport-github-review-bot
Bot
removed request for
Tener and
timothyb89
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
Contributor
Author
|
I thought these commits would be squashed, in the future I will cleanup the history first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #31721 to branch/v14